Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance description of sync_changelog #861

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nforro
Copy link
Member

@nforro nforro commented Mar 28, 2024

No description provided.

Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! But I am thinking about whether we shouldn't change this behaviour, it doesn't really align with the option name (we would need to check who is using this option).

@LecrisUT
Copy link
Contributor

tmt is using it. The thing is in the %changelog the verison/release numbers are used, so it makes sense to imply that packit does not update version, but I think packit should fail if it is not set to not update the version. Then intent is more specific.

@martinhoyer
Copy link
Contributor

it doesn't really align with the option name

+1. It is a bit misleading, even with the documentation change.
Would it be hard to implement sync_changelog=true to not affect the other ways .spec is being processed, like Version, Release updates?
Although I'm not sure if it make sense - if a project is making .spec file changes outside of packit, it might as well handle the rest. Perhaps renaming it from sync_changelog to something that implies it's "syncing the whole spec" would be a way?

Why do projects, like tmt, don't use packit for generating changelog?

@nforro
Copy link
Member Author

nforro commented Apr 2, 2024

Perhaps renaming it from sync_changelog to something that implies it's "syncing the whole spec" would be a way?

Yes, this would make the most sense to me. Any ideas how to call it?

@nforro nforro added discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) and removed discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) labels Apr 2, 2024
@nforro
Copy link
Member Author

nforro commented Apr 2, 2024

Let's discuss this on the next architecture meeting. @martinhoyer in case you would like to participate, let me know and I'll invite you.

@martinhoyer
Copy link
Contributor

martinhoyer commented Apr 2, 2024

Let's discuss this on the next architecture meeting. @martinhoyer in case you would like to participate, let me know and I'll invite you.

Thanks, I probably don't have much to add due to the lack of experience with packit (and in general), so all I have to say is in the above comment. To recap:

  • Is there a need for someone to only sync the changelog?
    • If yes, why? Would being able to customize the changelog generation in some way help?
    • If not, I'd just rename it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants